1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
|
// SPDX-License-Identifier: MIT
/*
* Copyright © 2025 Intel Corporation
*/
#include "xe_vm_madvise.h"
#include <linux/nospec.h>
#include <drm/xe_drm.h>
#include "xe_bo.h"
#include "xe_pat.h"
#include "xe_pt.h"
#include "xe_svm.h"
struct xe_vmas_in_madvise_range {
u64 addr;
u64 range;
struct xe_vma **vmas;
int num_vmas;
bool has_bo_vmas;
bool has_svm_userptr_vmas;
};
/**
* struct xe_madvise_details - Argument to madvise_funcs
* @dpagemap: Reference-counted pointer to a struct drm_pagemap.
*
* The madvise IOCTL handler may, in addition to the user-space
* args, have additional info to pass into the madvise_func that
* handles the madvise type. Use a struct_xe_madvise_details
* for that and extend the struct as necessary.
*/
struct xe_madvise_details {
struct drm_pagemap *dpagemap;
};
static int get_vmas(struct xe_vm *vm, struct xe_vmas_in_madvise_range *madvise_range)
{
u64 addr = madvise_range->addr;
u64 range = madvise_range->range;
struct xe_vma **__vmas;
struct drm_gpuva *gpuva;
int max_vmas = 8;
lockdep_assert_held(&vm->lock);
madvise_range->num_vmas = 0;
madvise_range->vmas = kmalloc_objs(*madvise_range->vmas, max_vmas);
if (!madvise_range->vmas)
return -ENOMEM;
vm_dbg(&vm->xe->drm, "VMA's in range: start=0x%016llx, end=0x%016llx", addr, addr + range);
drm_gpuvm_for_each_va_range(gpuva, &vm->gpuvm, addr, addr + range) {
struct xe_vma *vma = gpuva_to_vma(gpuva);
if (xe_vma_bo(vma))
madvise_range->has_bo_vmas = true;
else if (xe_vma_is_cpu_addr_mirror(vma) || xe_vma_is_userptr(vma))
madvise_range->has_svm_userptr_vmas = true;
if (madvise_range->num_vmas == max_vmas) {
max_vmas <<= 1;
__vmas = krealloc(madvise_range->vmas,
max_vmas * sizeof(*madvise_range->vmas),
GFP_KERNEL);
if (!__vmas) {
kfree(madvise_range->vmas);
return -ENOMEM;
}
madvise_range->vmas = __vmas;
}
madvise_range->vmas[madvise_range->num_vmas] = vma;
(madvise_range->num_vmas)++;
}
if (!madvise_range->num_vmas)
kfree(madvise_range->vmas);
vm_dbg(&vm->xe->drm, "madvise_range-num_vmas = %d\n", madvise_range->num_vmas);
return 0;
}
static void madvise_preferred_mem_loc(struct xe_device *xe, struct xe_vm *vm,
struct xe_vma **vmas, int num_vmas,
struct drm_xe_madvise *op,
struct xe_madvise_details *details)
{
int i;
xe_assert(vm->xe, op->type == DRM_XE_MEM_RANGE_ATTR_PREFERRED_LOC);
for (i = 0; i < num_vmas; i++) {
struct xe_vma *vma = vmas[i];
struct xe_vma_preferred_loc *loc = &vma->attr.preferred_loc;
/*TODO: Extend attributes to bo based vmas */
if ((loc->devmem_fd == op->preferred_mem_loc.devmem_fd &&
loc->migration_policy == op->preferred_mem_loc.migration_policy) ||
!xe_vma_is_cpu_addr_mirror(vma)) {
vma->skip_invalidation = true;
} else {
vma->skip_invalidation = false;
loc->devmem_fd = op->preferred_mem_loc.devmem_fd;
/* Till multi-device support is not added migration_policy
* is of no use and can be ignored.
*/
loc->migration_policy = op->preferred_mem_loc.migration_policy;
drm_pagemap_put(loc->dpagemap);
loc->dpagemap = NULL;
if (details->dpagemap)
loc->dpagemap = drm_pagemap_get(details->dpagemap);
}
}
}
static void madvise_atomic(struct xe_device *xe, struct xe_vm *vm,
struct xe_vma **vmas, int num_vmas,
struct drm_xe_madvise *op,
struct xe_madvise_details *details)
{
struct xe_bo *bo;
int i;
xe_assert(vm->xe, op->type == DRM_XE_MEM_RANGE_ATTR_ATOMIC);
xe_assert(vm->xe, op->atomic.val <= DRM_XE_ATOMIC_CPU);
for (i = 0; i < num_vmas; i++) {
if (xe_vma_is_userptr(vmas[i]) &&
!(op->atomic.val == DRM_XE_ATOMIC_DEVICE &&
xe->info.has_device_atomics_on_smem)) {
vmas[i]->skip_invalidation = true;
continue;
}
if (vmas[i]->attr.atomic_access == op->atomic.val) {
vmas[i]->skip_invalidation = true;
} else {
vmas[i]->skip_invalidation = false;
vmas[i]->attr.atomic_access = op->atomic.val;
}
bo = xe_vma_bo(vmas[i]);
if (!bo || bo->attr.atomic_access == op->atomic.val)
continue;
vmas[i]->skip_invalidation = false;
xe_bo_assert_held(bo);
bo->attr.atomic_access = op->atomic.val;
/* Invalidate cpu page table, so bo can migrate to smem in next access */
if (xe_bo_is_vram(bo) &&
(bo->attr.atomic_access == DRM_XE_ATOMIC_CPU ||
bo->attr.atomic_access == DRM_XE_ATOMIC_GLOBAL))
ttm_bo_unmap_virtual(&bo->ttm);
}
}
static void madvise_pat_index(struct xe_device *xe, struct xe_vm *vm,
struct xe_vma **vmas, int num_vmas,
struct drm_xe_madvise *op,
struct xe_madvise_details *details)
{
int i;
xe_assert(vm->xe, op->type == DRM_XE_MEM_RANGE_ATTR_PAT);
for (i = 0; i < num_vmas; i++) {
if (vmas[i]->attr.pat_index == op->pat_index.val) {
vmas[i]->skip_invalidation = true;
} else {
vmas[i]->skip_invalidation = false;
vmas[i]->attr.pat_index = op->pat_index.val;
}
}
}
typedef void (*madvise_func)(struct xe_device *xe, struct xe_vm *vm,
struct xe_vma **vmas, int num_vmas,
struct drm_xe_madvise *op,
struct xe_madvise_details *details);
static const madvise_func madvise_funcs[] = {
[DRM_XE_MEM_RANGE_ATTR_PREFERRED_LOC] = madvise_preferred_mem_loc,
[DRM_XE_MEM_RANGE_ATTR_ATOMIC] = madvise_atomic,
[DRM_XE_MEM_RANGE_ATTR_PAT] = madvise_pat_index,
};
static u8 xe_zap_ptes_in_madvise_range(struct xe_vm *vm, u64 start, u64 end)
{
struct drm_gpuva *gpuva;
struct xe_tile *tile;
u8 id, tile_mask = 0;
lockdep_assert_held_write(&vm->lock);
/* Wait for pending binds */
if (dma_resv_wait_timeout(xe_vm_resv(vm), DMA_RESV_USAGE_BOOKKEEP,
false, MAX_SCHEDULE_TIMEOUT) <= 0)
XE_WARN_ON(1);
drm_gpuvm_for_each_va_range(gpuva, &vm->gpuvm, start, end) {
struct xe_vma *vma = gpuva_to_vma(gpuva);
if (vma->skip_invalidation || xe_vma_is_null(vma))
continue;
if (xe_vma_is_cpu_addr_mirror(vma)) {
tile_mask |= xe_svm_ranges_zap_ptes_in_range(vm,
xe_vma_start(vma),
xe_vma_end(vma));
} else {
for_each_tile(tile, vm->xe, id) {
if (xe_pt_zap_ptes(tile, vma)) {
tile_mask |= BIT(id);
/*
* WRITE_ONCE pairs with READ_ONCE
* in xe_vm_has_valid_gpu_mapping()
*/
WRITE_ONCE(vma->tile_invalidated,
vma->tile_invalidated | BIT(id));
}
}
}
}
return tile_mask;
}
static int xe_vm_invalidate_madvise_range(struct xe_vm *vm, u64 start, u64 end)
{
u8 tile_mask = xe_zap_ptes_in_madvise_range(vm, start, end);
if (!tile_mask)
return 0;
xe_device_wmb(vm->xe);
return xe_vm_range_tilemask_tlb_inval(vm, start, end, tile_mask);
}
static bool madvise_args_are_sane(struct xe_device *xe, const struct drm_xe_madvise *args)
{
if (XE_IOCTL_DBG(xe, !args))
return false;
if (XE_IOCTL_DBG(xe, !IS_ALIGNED(args->start, SZ_4K)))
return false;
if (XE_IOCTL_DBG(xe, !IS_ALIGNED(args->range, SZ_4K)))
return false;
if (XE_IOCTL_DBG(xe, args->range < SZ_4K))
return false;
switch (args->type) {
case DRM_XE_MEM_RANGE_ATTR_PREFERRED_LOC:
{
s32 fd = (s32)args->preferred_mem_loc.devmem_fd;
if (XE_IOCTL_DBG(xe, fd < DRM_XE_PREFERRED_LOC_DEFAULT_SYSTEM))
return false;
if (XE_IOCTL_DBG(xe, fd <= DRM_XE_PREFERRED_LOC_DEFAULT_DEVICE &&
args->preferred_mem_loc.region_instance != 0))
return false;
if (XE_IOCTL_DBG(xe, args->preferred_mem_loc.migration_policy >
DRM_XE_MIGRATE_ONLY_SYSTEM_PAGES))
return false;
if (XE_IOCTL_DBG(xe, args->preferred_mem_loc.reserved))
return false;
break;
}
case DRM_XE_MEM_RANGE_ATTR_ATOMIC:
if (XE_IOCTL_DBG(xe, args->atomic.val > DRM_XE_ATOMIC_CPU))
return false;
if (XE_IOCTL_DBG(xe, args->atomic.pad))
return false;
if (XE_IOCTL_DBG(xe, args->atomic.reserved))
return false;
break;
case DRM_XE_MEM_RANGE_ATTR_PAT:
{
u16 pat_index, coh_mode;
if (XE_IOCTL_DBG(xe, args->pat_index.val >= xe->pat.n_entries))
return false;
pat_index = array_index_nospec(args->pat_index.val, xe->pat.n_entries);
coh_mode = xe_pat_index_get_coh_mode(xe, pat_index);
if (XE_IOCTL_DBG(xe, !coh_mode))
return false;
if (XE_WARN_ON(coh_mode > XE_COH_AT_LEAST_1WAY))
return false;
if (XE_IOCTL_DBG(xe, args->pat_index.pad))
return false;
if (XE_IOCTL_DBG(xe, args->pat_index.reserved))
return false;
break;
}
default:
if (XE_IOCTL_DBG(xe, 1))
return false;
}
if (XE_IOCTL_DBG(xe, args->reserved[0] || args->reserved[1]))
return false;
return true;
}
static int xe_madvise_details_init(struct xe_vm *vm, const struct drm_xe_madvise *args,
struct xe_madvise_details *details)
{
struct xe_device *xe = vm->xe;
memset(details, 0, sizeof(*details));
if (args->type == DRM_XE_MEM_RANGE_ATTR_PREFERRED_LOC) {
int fd = args->preferred_mem_loc.devmem_fd;
struct drm_pagemap *dpagemap;
if (fd <= 0)
return 0;
dpagemap = xe_drm_pagemap_from_fd(args->preferred_mem_loc.devmem_fd,
args->preferred_mem_loc.region_instance);
if (XE_IOCTL_DBG(xe, IS_ERR(dpagemap)))
return PTR_ERR(dpagemap);
/* Don't allow a foreign placement without a fast interconnect! */
if (XE_IOCTL_DBG(xe, dpagemap->pagemap->owner != vm->svm.peer.owner)) {
drm_pagemap_put(dpagemap);
return -ENOLINK;
}
details->dpagemap = dpagemap;
}
return 0;
}
static void xe_madvise_details_fini(struct xe_madvise_details *details)
{
drm_pagemap_put(details->dpagemap);
}
static bool check_bo_args_are_sane(struct xe_vm *vm, struct xe_vma **vmas,
int num_vmas, u32 atomic_val)
{
struct xe_device *xe = vm->xe;
struct xe_bo *bo;
int i;
for (i = 0; i < num_vmas; i++) {
bo = xe_vma_bo(vmas[i]);
if (!bo)
continue;
/*
* NOTE: The following atomic checks are platform-specific. For example,
* if a device supports CXL atomics, these may not be necessary or
* may behave differently.
*/
if (XE_IOCTL_DBG(xe, atomic_val == DRM_XE_ATOMIC_CPU &&
!(bo->flags & XE_BO_FLAG_SYSTEM)))
return false;
if (XE_IOCTL_DBG(xe, atomic_val == DRM_XE_ATOMIC_DEVICE &&
!(bo->flags & XE_BO_FLAG_VRAM0) &&
!(bo->flags & XE_BO_FLAG_VRAM1) &&
!(bo->flags & XE_BO_FLAG_SYSTEM &&
xe->info.has_device_atomics_on_smem)))
return false;
if (XE_IOCTL_DBG(xe, atomic_val == DRM_XE_ATOMIC_GLOBAL &&
(!(bo->flags & XE_BO_FLAG_SYSTEM) ||
(!(bo->flags & XE_BO_FLAG_VRAM0) &&
!(bo->flags & XE_BO_FLAG_VRAM1)))))
return false;
}
return true;
}
/**
* xe_vm_madvise_ioctl - Handle MADVise ioctl for a VM
* @dev: DRM device pointer
* @data: Pointer to ioctl data (drm_xe_madvise*)
* @file: DRM file pointer
*
* Handles the MADVISE ioctl to provide memory advice for vma's within
* input range.
*
* Return: 0 on success or a negative error code on failure.
*/
int xe_vm_madvise_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
{
struct xe_device *xe = to_xe_device(dev);
struct xe_file *xef = to_xe_file(file);
struct drm_xe_madvise *args = data;
struct xe_vmas_in_madvise_range madvise_range = {.addr = args->start,
.range = args->range, };
struct xe_madvise_details details;
struct xe_vm *vm;
struct drm_exec exec;
int err, attr_type;
vm = xe_vm_lookup(xef, args->vm_id);
if (XE_IOCTL_DBG(xe, !vm))
return -EINVAL;
if (!madvise_args_are_sane(vm->xe, args)) {
err = -EINVAL;
goto put_vm;
}
xe_svm_flush(vm);
err = down_write_killable(&vm->lock);
if (err)
goto put_vm;
if (XE_IOCTL_DBG(xe, xe_vm_is_closed_or_banned(vm))) {
err = -ENOENT;
goto unlock_vm;
}
err = xe_madvise_details_init(vm, args, &details);
if (err)
goto unlock_vm;
err = xe_vm_alloc_madvise_vma(vm, args->start, args->range);
if (err)
goto madv_fini;
err = get_vmas(vm, &madvise_range);
if (err || !madvise_range.num_vmas)
goto madv_fini;
if (madvise_range.has_bo_vmas) {
if (args->type == DRM_XE_MEM_RANGE_ATTR_ATOMIC) {
if (!check_bo_args_are_sane(vm, madvise_range.vmas,
madvise_range.num_vmas,
args->atomic.val)) {
err = -EINVAL;
goto free_vmas;
}
}
drm_exec_init(&exec, DRM_EXEC_IGNORE_DUPLICATES | DRM_EXEC_INTERRUPTIBLE_WAIT, 0);
drm_exec_until_all_locked(&exec) {
for (int i = 0; i < madvise_range.num_vmas; i++) {
struct xe_bo *bo = xe_vma_bo(madvise_range.vmas[i]);
if (!bo)
continue;
err = drm_exec_lock_obj(&exec, &bo->ttm.base);
drm_exec_retry_on_contention(&exec);
if (err)
goto err_fini;
}
}
}
if (madvise_range.has_svm_userptr_vmas) {
err = xe_svm_notifier_lock_interruptible(vm);
if (err)
goto err_fini;
}
attr_type = array_index_nospec(args->type, ARRAY_SIZE(madvise_funcs));
madvise_funcs[attr_type](xe, vm, madvise_range.vmas, madvise_range.num_vmas, args,
&details);
err = xe_vm_invalidate_madvise_range(vm, args->start, args->start + args->range);
if (madvise_range.has_svm_userptr_vmas)
xe_svm_notifier_unlock(vm);
err_fini:
if (madvise_range.has_bo_vmas)
drm_exec_fini(&exec);
free_vmas:
kfree(madvise_range.vmas);
madvise_range.vmas = NULL;
madv_fini:
xe_madvise_details_fini(&details);
unlock_vm:
up_write(&vm->lock);
put_vm:
xe_vm_put(vm);
return err;
}
|